-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue a warning instead of a syntax error for blif delay constraints #4153
Issue a warning instead of a syntax error for blif delay constraints #4153
Conversation
I'm getting a CI error with a mismatch on a test (specifically gcc-11 c++-11), but it seems to be already present on master |
Please rebase on master. GH actions are fixed meanwhile |
It seems that my branch is already based on latest master (2f9fcc2) |
Ah. This is since there is no variable defined on your github fork repo. Anyway it is important to run on our CI. |
The issue persists, and apparently it happens on other pull requests. |
The Icarus version that is used is the latest (0db1a0c). Given the message ( |
192b6aec96fde982e6ddcb28b346d5893aa8e874 is required version of iverilog |
Somehow the latest master is pulled. Is the Github variable set to 192b6aec96fde982e6ddcb28b346d5893aa8e874? |
Well it looks like variables are not working and are actually taken from PR person context which is not good in this case. Will put version in actions file |
Ok done a change, so please just rebase your fork and it should build on your side and as well in PR |
Very weird behaviour 😮 Thank you for the debugging |
Hi! Is there any other step for me to do before merging? |
Fix issue #4152